Skip to content

v1.4.22 cut#2647

Merged
akshaydeo merged 2 commits intomainfrom
04-11-v1.4.22_cut
Apr 11, 2026
Merged

v1.4.22 cut#2647
akshaydeo merged 2 commits intomainfrom
04-11-v1.4.22_cut

Conversation

@akshaydeo
Copy link
Copy Markdown
Contributor

@akshaydeo akshaydeo commented Apr 11, 2026

Summary

This release adds response parameter backfilling functionality to ensure chat completion and responses requests always have complete metadata fields, while cleaning up redundant code in the Mistral provider.

Changes

  • Added BackfillParams methods to BifrostChatResponse and BifrostResponsesResponse to automatically populate missing response fields like model, object type, and created timestamp
  • Removed custom provider key normalization and redundant OCR validation from Mistral provider to simplify the codebase
  • Fixed minor formatting inconsistencies in response type constants
  • Bumped core version to 1.4.19, framework to 1.2.38, and updated all dependent plugins and transports

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (Next.js)
  • Docs

How to test

Validate that response backfilling works correctly and Mistral provider functions without the removed validation:

# Core/Transports
go version
go test ./...

# Test chat completion responses have all required fields populated
# Test Mistral provider still works correctly without custom key normalization
# Verify OCR validation removal doesn't break functionality

Screenshots/Recordings

N/A

Breaking changes

  • Yes
  • No

Related issues

N/A

Security considerations

The removal of custom provider key normalization and OCR validation from Mistral provider should be reviewed to ensure no security regressions are introduced.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cd0d40ce-b003-49a7-8db5-6cf96bd09e6c

📥 Commits

Reviewing files that changed from the base of the PR and between 340f043 and e9e1e8f.

⛔ Files ignored due to path filters (13)
  • framework/go.sum is excluded by !**/*.sum
  • plugins/governance/go.sum is excluded by !**/*.sum
  • plugins/litellmcompat/go.sum is excluded by !**/*.sum
  • plugins/logging/go.sum is excluded by !**/*.sum
  • plugins/maxim/go.sum is excluded by !**/*.sum
  • plugins/otel/go.sum is excluded by !**/*.sum
  • plugins/semanticcache/go.sum is excluded by !**/*.sum
  • plugins/telemetry/go.sum is excluded by !**/*.sum
  • tests/integrations/python/uv.lock is excluded by !**/*.lock
  • tests/integrations/typescript/package-lock.json is excluded by !**/package-lock.json
  • tests/scripts/1millogs/go.sum is excluded by !**/*.sum
  • transports/go.sum is excluded by !**/*.sum
  • ui/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (38)
  • .github/workflows/scripts/run-migration-tests.sh
  • core/changelog.md
  • core/version
  • framework/changelog.md
  • framework/go.mod
  • framework/version
  • plugins/governance/changelog.md
  • plugins/governance/go.mod
  • plugins/governance/version
  • plugins/jsonparser/changelog.md
  • plugins/jsonparser/version
  • plugins/litellmcompat/changelog.md
  • plugins/litellmcompat/go.mod
  • plugins/litellmcompat/version
  • plugins/logging/changelog.md
  • plugins/logging/go.mod
  • plugins/logging/version
  • plugins/maxim/changelog.md
  • plugins/maxim/go.mod
  • plugins/maxim/version
  • plugins/mocker/changelog.md
  • plugins/mocker/version
  • plugins/otel/changelog.md
  • plugins/otel/go.mod
  • plugins/otel/version
  • plugins/semanticcache/changelog.md
  • plugins/semanticcache/go.mod
  • plugins/semanticcache/version
  • plugins/telemetry/changelog.md
  • plugins/telemetry/go.mod
  • plugins/telemetry/version
  • tests/integrations/typescript/package.json
  • tests/scripts/1millogs/go.mod
  • transports/Dockerfile.local
  • transports/changelog.md
  • transports/go.mod
  • transports/version
  • ui/package.json
✅ Files skipped from review due to trivial changes (33)
  • framework/version
  • plugins/maxim/changelog.md
  • plugins/litellmcompat/changelog.md
  • core/version
  • plugins/governance/changelog.md
  • plugins/mocker/version
  • plugins/jsonparser/changelog.md
  • plugins/otel/version
  • plugins/logging/changelog.md
  • plugins/semanticcache/changelog.md
  • plugins/jsonparser/version
  • framework/changelog.md
  • plugins/litellmcompat/version
  • plugins/otel/changelog.md
  • plugins/governance/version
  • plugins/telemetry/changelog.md
  • framework/go.mod
  • core/changelog.md
  • transports/version
  • plugins/otel/go.mod
  • plugins/logging/version
  • plugins/maxim/version
  • plugins/telemetry/version
  • plugins/telemetry/go.mod
  • plugins/mocker/changelog.md
  • plugins/logging/go.mod
  • ui/package.json
  • plugins/governance/go.mod
  • plugins/semanticcache/go.mod
  • plugins/maxim/go.mod
  • transports/Dockerfile.local
  • plugins/litellmcompat/go.mod
  • transports/go.mod
🚧 Files skipped from review as they are similar to previous changes (2)
  • plugins/semanticcache/version
  • transports/changelog.md

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Responses now consistently populate model, object/type, and creation timestamp; redundant provider behavior and duplicate OCR validation removed.
  • Chores

    • Platform components, plugins, and UI/test dependencies bumped and changelogs updated; container base images pinned and migration test fakers enhanced.

Walkthrough

Bumps versions across core, framework, transports, and many plugins; adds/edits changelog entries about response backfilling and Mistral provider cleanup; updates multiple indirect Go module versions; expands migration-test faker SQL; pins Docker base image digests; and updates several package.json and test go.mod dependencies.

Changes

Cohort / File(s) Summary
Core
core/changelog.md, core/version
Bumped core to 1.4.19; added changelog entries describing BackfillParams methods for responses, Mistral-provider normalization/validation removal, and minor response-constant formatting fix.
Framework
framework/changelog.md, framework/version
Bumped framework to 1.2.38; added top-of-file changelog entry noting core upgrade.
Transports
transports/changelog.md, transports/version, transports/Dockerfile.local
Bumped transports to 1.4.22; restructured transports changelog and noted response backfilling and Mistral cleanup; Dockerfile.local base images pinned to digests.
Plugins (changelogs + versions)
plugins/*/changelog.md, plugins/*/version
Many plugins had single-line changelog entries noting core/framework upgrades and had their version files incremented (patch/minor bumps).
Go module indirect updates
framework/go.mod, transports/go.mod, plugins/*/go.mod
Updated indirect github.com/jackc/pgx/v5 (and related indirects) from v5.7.6v5.9.1 across multiple go.mod files.
Migration-test script
.github/workflows/scripts/run-migration-tests.sh
Extended migration-test faker SQL to dynamically UPDATE/clear newly added governance_model_pricing and log-related columns (Postgres + SQLite guards/variants).
Tests & build deps
tests/integrations/typescript/package.json, tests/scripts/1millogs/go.mod
Updated TypeScript test dependencies (LangChain bumps) and substantially updated tests/scripts/1millogs/go.mod toolchain and many direct/indirect deps.
UI
ui/package.json
Bumped axios and next dependency versions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • v1.4.19 cut #2430 — touches the same migration-tests faker script and seed data updates.
  • release cut #2532 — adds schema-conditional migration-test SQL similar to updates here.
  • cve fixes #2607 — overlaps on Go toolchain/dependency and Dockerfile base-image updates.

Suggested reviewers

  • danpiths
  • Pratham-Mishra04

Poem

🐰 I hopped through versions, light and keen,
core and framework polished to sheen.
Plugins pranced, migrations got a tweak,
Docker pinned, tests beefed for compatibility’s week.
A joyful nibble — release-ready scene!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'v1.4.22 cut' is vague and lacks specificity about the actual changes made in the PR. Consider using a more descriptive title that highlights the main changes, such as 'Add response parameter backfilling and cleanup Mistral provider' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The PR description follows the template structure and includes most required sections with adequate detail about changes, testing approach, and impact assessment.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 04-11-v1.4.22_cut

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@akshaydeo akshaydeo marked this pull request as ready for review April 11, 2026 08:45
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 11, 2026

Confidence Score: 5/5

Safe to merge; all findings are P2 style suggestions with no blocking issues.

The diff is a routine release cut: version bumps, changelogs, migration test additions, Docker SHA pinning, and a pgx dependency upgrade. No logic changes to production Go code are introduced. The single comment is a non-blocking style inconsistency in the CI test script.

.github/workflows/scripts/run-migration-tests.sh — minor inconsistency between SQLite and Postgres column-guard patterns for the two new log-store columns.

Important Files Changed

Filename Overview
.github/workflows/scripts/run-migration-tests.sh Adds v1.4.21 migration test coverage for governance_model_pricing 272k/priority-tier pricing columns and log-store columns (logs.ocr_output, mcp_tool_logs.request_id). Postgres uses column_exists guards for all new entries; SQLite emits the log-store UPDATEs unconditionally (error swallowed by `
transports/Dockerfile.local Pins all three base images (node:25-alpine3.23, golang:1.26.2-alpine3.23, alpine:3.23.3) to their SHA256 digests, improving build reproducibility and preventing unexpected image changes.
framework/go.mod Upgrades github.com/jackc/pgx/v5 from v5.7.6 to v5.9.1.
transports/go.mod Upgrades github.com/jackc/pgx/v5 from v5.7.6 to v5.9.1, matching the framework module.
core/version Routine version bump as part of the v1.4.22 release cut.

Reviews (4): Last reviewed commit: "Merge branch 'main' into 04-11-v1.4.22_c..." | Re-trigger Greptile

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 11, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 11, 2026
Copy link
Copy Markdown
Contributor Author

akshaydeo commented Apr 11, 2026

Merge activity

  • Apr 11, 11:25 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 11, 11:25 AM UTC: @akshaydeo merged this pull request with Graphite.

@akshaydeo akshaydeo merged commit 12ab7f4 into main Apr 11, 2026
15 of 18 checks passed
@akshaydeo akshaydeo deleted the 04-11-v1.4.22_cut branch April 11, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants